Cli to rpc #126

binarybaron · 2022-12-20T07:56:11Z

No description provided.

…s to using the RPC API

…prettify DebugPage and Logging

binarybaron · 2023-08-29T21:55:31Z

@CodiumAI-Agent /review

CodiumAI-Agent · 2023-08-29T21:56:45Z

PR Analysis

🎯 Main theme: Migrating from CLI to RPC
📝 PR summary: This PR is about migrating the application from using a CLI process to using the RPC API. This includes changes in the main.ts file, the rpc.ts file, and the providersSlice.ts file. The PR also includes the removal of several files that were related to the CLI process.
📌 Type of PR: Refactoring
🧪 Relevant tests added: No
🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: The PR is well-structured and the changes are well-documented. The code is clean and follows good practices. However, it would be beneficial to add tests for the new RPC methods to ensure they work as expected. Also, it would be helpful to add error handling for the RPC calls to ensure the application can recover gracefully from any errors.
🤖 Code feedback:
- relevant file: src/main/cli/rpc.ts
  suggestion: Consider adding error handling for the RPC calls. This can be done by wrapping the RPC calls in a try-catch block and handling any errors that may occur. This will ensure that the application can recover gracefully from any errors and provide a better user experience. [important]
  relevant line: "+const rpcClient = jayson.Client.http({"
- relevant file: src/main/cli/rpc.ts
  suggestion: It would be beneficial to add tests for the new RPC methods to ensure they work as expected. This will help catch any bugs or issues early in the development process and ensure the quality of the code. [important]
  relevant line: "+export async function makeRpcRequest("
- relevant file: src/main/main.ts
  suggestion: Consider refactoring the code to avoid the use of setInterval. Using setInterval can lead to issues if the function it calls takes longer to execute than the interval time. Instead, consider using recursive setTimeout or async/await with a delay to ensure the previous function call has completed before the next one is made. [medium]
  relevant line: "+setInterval(() => {"

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

binarybaron · 2023-08-29T22:15:28Z

@CodiumAI-Agent /improve --extended

CodiumAI-Agent · 2023-08-29T22:24:37Z

src/main/cli/cli.ts


              cli.on('exit', async (code, signal) => {
                logger.info({ subCommand, code, signal }, `CLI excited`);
-
+                onExit(code, signal);
+                resolveRunning();
                cli = null;
-
-                try {
-                  await readFromDatabaseAndUpdateState();
-                } finally {
-                  onExit(code, signal);
-                  resolveRunning();
-                }
              });

              [cli.stderr, cli.stdout].forEach((stream) => {
                stream.setEncoding('utf8');
                stream.on('data', (data: string) => {
                  onStdOut(data);

-                  const logs = getLinesOfString(data)
-                    .map((logText) => {
-                      logger.debug(
-                        { subCommand, logText: logText.trim() },
-                        'Received stdout from cli process'
-                      );
-
-                      try {
-                        return JSON.parse(logText);
-                      } catch (err) {
-                        logger.debug(
-                          {
-                            subCommand,
-                            logText,
-                            err,
-                          },
-                          'Failed to parse CLI log'
-                        );
-                      }
-                      return null;
-                    })
-                    .filter(isCliLog);
+                  logger.debug({ subCommand, data }, `CLI stdout`);
+                  const logs = getLogsFromRawFileString(data);

                  onLog(logs);
-
-                  readFromDatabaseAndUpdateState();
                });
              });
            } catch (e) {


Suggestion: Consider handling the error in the catch block at line 154. Currently, the error is caught but not handled, which could lead to unexpected behavior.

Suggested change

cli.on('exit', async (code, signal) => {

logger.info({ subCommand, code, signal }, `CLI excited`);

onExit(code, signal);

resolveRunning();

cli = null;

try {

await readFromDatabaseAndUpdateState();

} finally {

onExit(code, signal);

resolveRunning();

}

});

[cli.stderr, cli.stdout].forEach((stream) => {

stream.setEncoding('utf8');

stream.on('data', (data: string) => {

onStdOut(data);

const logs = getLinesOfString(data)

.map((logText) => {

logger.debug(

{ subCommand, logText: logText.trim() },

'Received stdout from cli process'

);

try {

return JSON.parse(logText);

} catch (err) {

logger.debug(

{

subCommand,

logText,

err,

},

'Failed to parse CLI log'

);

}

return null;

})

.filter(isCliLog);

logger.debug({ subCommand, data }, `CLI stdout`);

const logs = getLogsFromRawFileString(data);

onLog(logs);

readFromDatabaseAndUpdateState();

});

});

} catch (e) {

try {

...

} catch (e) {

logger.error(`Error occurred: ${e.message}`);

}

CodiumAI-Agent · 2023-08-29T22:24:38Z

src/main/cli/cli.ts

+export async function startRPC() {
+  await spawnSubcommand(
+    'start-daemon',
+    {
+      'server-address': `${RPC_BIND_HOST}:${RPC_BIND_PORT}`,
+    },
+    (logs) => {
+      store.dispatch(rpcAddLogs(logs));
+      RPC_LOG_EVENT_EMITTER.emit(logs);
+    },
+    (exitCode, exitSignal) => {
+      store.dispatch(rpcProcessExited({ exitCode, exitSignal }));
+      logger.error('RPC server has stopped');
+    },
+    (text) => {
+      store.dispatch(rpcAppendStdOut(text));
+    }
+  );
+  store.dispatch(rpcInitiate());
+}


Suggestion: Consider adding error handling for the async function 'startRPC' at line 166. Currently, if an error occurs during the execution of 'spawnSubcommand', it will not be caught and could lead to unexpected behavior.

Suggested change

export async function startRPC() {

await spawnSubcommand(

'start-daemon',

{

'server-address': `${RPC_BIND_HOST}:${RPC_BIND_PORT}`,

},

(logs) => {

store.dispatch(rpcAddLogs(logs));

RPC_LOG_EVENT_EMITTER.emit(logs);

},

(exitCode, exitSignal) => {

store.dispatch(rpcProcessExited({ exitCode, exitSignal }));

logger.error('RPC server has stopped');

},

(text) => {

store.dispatch(rpcAppendStdOut(text));

}

);

store.dispatch(rpcInitiate());

}

export async function startRPC() {

try {

await spawnSubcommand(...);

...

} catch (e) {

logger.error(`Error occurred: ${e.message}`);

}

}

CodiumAI-Agent · 2023-08-29T22:24:39Z

src/main/cli/dirs.ts

+export default async function getSavedLogsOfSwapId(
+  swapId: string
+): Promise<CliLog[]> {
+  const logsFile = await getCliLogFile();
+  const fileData = await getFileData(logsFile);
+  const allLogs = getLogsFromRawFileString(fileData);
+
+  return allLogs.filter((log) => getCliLogSpanSwapId(log) === swapId);
 }


Suggestion: Consider adding error handling for the async function 'getSavedLogsOfSwapId' at line 128. Currently, if an error occurs during the execution of 'getCliLogFile' or 'getFileData', it will not be caught and could lead to unexpected behavior.

Suggested change

export default async function getSavedLogsOfSwapId(

swapId: string

): Promise<CliLog[]> {

const logsFile = await getCliLogFile();

const fileData = await getFileData(logsFile);

const allLogs = getLogsFromRawFileString(fileData);

return allLogs.filter((log) => getCliLogSpanSwapId(log) === swapId);

}

export default async function getSavedLogsOfSwapId(swapId: string): Promise<CliLog[]> {

try {

const logsFile = await getCliLogFile();

const fileData = await getFileData(logsFile);

...

} catch (e) {

logger.error(`Error occurred: ${e.message}`);

}

}

CodiumAI-Agent · 2023-08-29T22:24:39Z

src/main/cli/rpc.ts

+export async function checkBitcoinBalance() {
+  const response = await makeRpcRequest<BalanceBitcoinResponse>(
+    RpcMethod.GET_BTC_BALANCE,
+    {}
+  );
+  store.dispatch(rpcSetBalance(response.balance));
+}


Suggestion: Consider adding error handling for the async function 'checkBitcoinBalance' at line 179. Currently, if an error occurs during the execution of 'makeRpcRequest', it will not be caught and could lead to unexpected behavior.

Suggested change

export async function checkBitcoinBalance() {

const response = await makeRpcRequest<BalanceBitcoinResponse>(

RpcMethod.GET_BTC_BALANCE,

{}

);

store.dispatch(rpcSetBalance(response.balance));

}

export async function checkBitcoinBalance() {

try {

const response = await makeRpcRequest<BalanceBitcoinResponse>(RpcMethod.GET_BTC_BALANCE, {});

...

} catch (e) {

logger.error(`Error occurred: ${e.message}`);

}

}

CodiumAI-Agent · 2023-08-29T22:24:40Z

src/main/cli/rpc.ts

+export async function withdrawAllBitcoin(address: string) {
+  store.dispatch(rpcResetWithdrawTxId());
+  const response = await makeRpcRequest<WithdrawBitcoinResponse>(
+    RpcMethod.WITHDRAW_BTC,
+    {
+      address,
+    }
+  );
+  store.dispatch(rpcSetWithdrawTxId(response.txid));
+}


Suggestion: Consider adding error handling for the async function 'withdrawAllBitcoin' at line 187. Currently, if an error occurs during the execution of 'makeRpcRequest', it will not be caught and could lead to unexpected behavior.

Suggested change

export async function withdrawAllBitcoin(address: string) {

store.dispatch(rpcResetWithdrawTxId());

const response = await makeRpcRequest<WithdrawBitcoinResponse>(

RpcMethod.WITHDRAW_BTC,

{

address,

}

);

store.dispatch(rpcSetWithdrawTxId(response.txid));

}

export async function withdrawAllBitcoin(address: string) {

try {

store.dispatch(rpcResetWithdrawTxId());

const response = await makeRpcRequest<WithdrawBitcoinResponse>(RpcMethod.WITHDRAW_BTC, {address});

...

} catch (e) {

logger.error(`Error occurred: ${e.message}`);

}

}

CodiumAI-Agent · 2023-08-29T22:24:41Z

src/main/cli/rpc.ts

+export async function getSwapInfo(swapId: string) {
+  return makeRpcRequest<GetSwapInfoResponse>(RpcMethod.GET_SWAP_INFO, {
+    swap_id: swapId,
+  });
+}


Suggestion: Consider adding error handling for the async function 'getSwapInfo' at line 198. Currently, if an error occurs during the execution of 'makeRpcRequest', it will not be caught and could lead to unexpected behavior.

Suggested change

export async function getSwapInfo(swapId: string) {

return makeRpcRequest<GetSwapInfoResponse>(RpcMethod.GET_SWAP_INFO, {

swap_id: swapId,

});

}

export async function getSwapInfo(swapId: string) {

try {

return makeRpcRequest<GetSwapInfoResponse>(RpcMethod.GET_SWAP_INFO, {swap_id: swapId});

} catch (e) {

logger.error(`Error occurred: ${e.message}`);

}

}

CodiumAI-Agent · 2023-08-29T22:24:42Z

src/main/cli/rpc.ts

+export async function buyXmr(
+  redeemAddress: string,
+  refundAddress: string,
+  provider: Provider
+) {
+  const { swapId } = await makeRpcRequest<BuyXmrResponse>(
+    RpcMethod.BUY_XMR,
+    {
+      bitcoin_change_address: refundAddress,
+      monero_receive_address: redeemAddress,
+      seller: providerToConcatenatedMultiAddr(provider),
+    },
+    (logs) => {
+      store.dispatch(
+        swapAddLog({
+          logs,
+          isFromRestore: false,
+        })
+      );
+    },
+    true
+  );
+
+  store.dispatch(
+    swapInitiate({
+      provider,
+      spawnType: SwapSpawnType.INIT,
+      swapId,
+    })
+  );
+}


Suggestion: Consider adding error handling for the async function 'buyXmr' at line 215. Currently, if an error occurs during the execution of 'makeRpcRequest', it will not be caught and could lead to unexpected behavior.

Suggested change

export async function buyXmr(

redeemAddress: string,

refundAddress: string,

provider: Provider

) {

const { swapId } = await makeRpcRequest<BuyXmrResponse>(

RpcMethod.BUY_XMR,

{

bitcoin_change_address: refundAddress,

monero_receive_address: redeemAddress,

seller: providerToConcatenatedMultiAddr(provider),

},

(logs) => {

store.dispatch(

swapAddLog({

logs,

isFromRestore: false,

})

);

},

true

);

store.dispatch(

swapInitiate({

provider,

spawnType: SwapSpawnType.INIT,

swapId,

})

);

}

export async function buyXmr(redeemAddress: string, refundAddress: string, provider: Provider) {

try {

const { swapId } = await makeRpcRequest<BuyXmrResponse>(RpcMethod.BUY_XMR, {...});

...

} catch (e) {

logger.error(`Error occurred: ${e.message}`);

}

}

CodiumAI-Agent · 2023-08-29T22:24:43Z

src/main/cli/rpc.ts

+export async function cancelRefundSwap(swapId: string) {
+  const swapInfo = await getSwapInfo(swapId);
+  const previousLogs = await getSavedLogsOfSwapId(swapId);
+
+  store.dispatch(
+    swapInitiate({
+      provider: providerFromGetSellerResponse(swapInfo.seller),
+      spawnType: SwapSpawnType.CANCEL_REFUND,
+      swapId,
+    })
+  );
+
+  store.dispatch(
+    swapAddLog({
+      logs: previousLogs,
+      isFromRestore: true,
+    })
+  );
+
+  await makeRpcRequest(
+    RpcMethod.CANCEL_REFUND_SWAP,
+    {
+      swap_id: swapId,
+    },
+    (logs) => {
+      store.dispatch(
+        swapAddLog({
+          logs,
+          isFromRestore: false,
+        })
+      );
+    },
+    true
+  );
+}


Suggestion: Consider adding error handling for the async function 'cancelRefundSwap' at line 247. Currently, if an error occurs during the execution of 'getSwapInfo', 'getSavedLogsOfSwapId' or 'makeRpcRequest', it will not be caught and could lead to unexpected behavior.

Suggested change

export async function cancelRefundSwap(swapId: string) {

const swapInfo = await getSwapInfo(swapId);

const previousLogs = await getSavedLogsOfSwapId(swapId);

store.dispatch(

swapInitiate({

provider: providerFromGetSellerResponse(swapInfo.seller),

spawnType: SwapSpawnType.CANCEL_REFUND,

swapId,

})

);

store.dispatch(

swapAddLog({

logs: previousLogs,

isFromRestore: true,

})

);

await makeRpcRequest(

RpcMethod.CANCEL_REFUND_SWAP,

{

swap_id: swapId,

},

(logs) => {

store.dispatch(

swapAddLog({

logs,

isFromRestore: false,

})

);

},

true

);

}

export async function cancelRefundSwap(swapId: string) {

try {

const swapInfo = await getSwapInfo(swapId);

const previousLogs = await getSavedLogsOfSwapId(swapId);

...

} catch (e) {

logger.error(`Error occurred: ${e.message}`);

}

}

CodiumAI-Agent · 2023-08-29T22:24:44Z

src/main/main.ts

    .whenReady()
    .then(async () => {
      createWindow();
-      registerIpcHandlers();
      initSocket();
-      watchDatabase();
-      spawnBalanceCheck();
-      watchElectrumTransactions();
-      watchLogs();
-      initStats();
+      startRPC();
+
+      setInterval(() => {
+        getRawSwapInfos();
+      }, 1000 * 20);
+
      return 0;
    })
    .catch((e) =>


Suggestion: Consider using a more robust error handling strategy. Currently, if an error occurs during the execution of the 'whenReady' function, the error is simply logged and the execution continues. This might lead to unexpected behavior later in the execution. Consider throwing the error or handling it in a way that prevents further execution in case of a critical failure.

Suggested change

.whenReady()

.then(async () => {

createWindow();

registerIpcHandlers();

initSocket();

watchDatabase();

spawnBalanceCheck();

watchElectrumTransactions();

watchLogs();

initStats();

startRPC();

setInterval(() => {

getRawSwapInfos();

}, 1000 * 20);

return 0;

})

.catch((e) =>

try {

await app.whenReady();

createWindow();

initSocket();

startRPC();

setInterval(() => {

getRawSwapInfos();

}, 1000 * 20);

} catch (e) {

logger.error(

{ error: e.toString() },

'Failed to initialize application'

);

throw e;

}

CodiumAI-Agent · 2023-08-29T22:24:45Z

src/main/main.ts

+export function sendSnackbarAlertToRenderer(
+  message: string,
+  variant: string,
+  autoHideDuration: number | null,
+  key: string | null
+) {
+  function send() {
+    logger.debug(
+      { message, variant, autoHideDuration, key },
+      'Attempting to send snackbar alert to renderer'
+    );
+    if (mainWindow) {
+      if (
+        mainWindow.webContents.isDestroyed() ||
+        mainWindow.webContents.isLoading()
+      ) {
+        logger.debug(
+          'Main window is loading, waiting for it to finish before sending snackbar alert'
+        );
+        mainWindow.webContents.once('did-finish-load', () =>
+          setTimeout(send, 5000)
+        );
+      } else {
+        logger.debug(
+          { message, variant, autoHideDuration, key },
+          'Sending snackbar alert to renderer'
+        );
+        mainWindow?.webContents.send(
+          'display-snackbar-alert',
+          message,
+          variant,
+          autoHideDuration,
+          key
+        );
+      }
+    } else {
+      setTimeout(send, 1000);
+    }
+  }
+  send();
+}


Suggestion: Consider using a more robust error handling strategy. Currently, if an error occurs during the execution of the 'sendSnackbarAlertToRenderer' function, the error is simply logged and the execution continues. This might lead to unexpected behavior later in the execution. Consider throwing the error or handling it in a way that prevents further execution in case of a critical failure.

Suggested change

export function sendSnackbarAlertToRenderer(

message: string,

variant: string,

autoHideDuration: number | null,

key: string | null

) {

function send() {

logger.debug(

{ message, variant, autoHideDuration, key },

'Attempting to send snackbar alert to renderer'

);

if (mainWindow) {

if (

mainWindow.webContents.isDestroyed() ||

mainWindow.webContents.isLoading()

) {

logger.debug(

'Main window is loading, waiting for it to finish before sending snackbar alert'

);

mainWindow.webContents.once('did-finish-load', () =>

setTimeout(send, 5000)

);

} else {

logger.debug(

{ message, variant, autoHideDuration, key },

'Sending snackbar alert to renderer'

);

mainWindow?.webContents.send(

'display-snackbar-alert',

message,

variant,

autoHideDuration,

key

);

}

} else {

setTimeout(send, 1000);

}

}

send();

}

export function sendSnackbarAlertToRenderer(

message: string,

variant: string,

autoHideDuration: number | null,

key: string | null

) {

function send() {

logger.debug(

{ message, variant, autoHideDuration, key },

'Attempting to send snackbar alert to renderer'

);

if (mainWindow) {

if (

mainWindow.webContents.isDestroyed() ||

mainWindow.webContents.isLoading()

) {

logger.debug(

'Main window is loading, waiting for it to finish before sending snackbar alert'

);

mainWindow.webContents.once('did-finish-load', () =>

setTimeout(send, 5000)

);

} else {

logger.debug(

{ message, variant, autoHideDuration, key },

'Sending snackbar alert to renderer'

);

try {

mainWindow?.webContents.send(

'display-snackbar-alert',

message,

variant,

autoHideDuration,

key

);

} catch (e) {

logger.error(

{ error: e.toString() },

'Failed to send snackbar alert to renderer'

);

throw e;

}

}

} else {

setTimeout(send, 1000);

}

}

send();

}

CodiumAI-Agent · 2023-08-29T22:24:46Z

src/models/databaseModel.ts

+export function getSwapTxFees(swap: GetSwapInfoResponse): number {
+  // TODO
+  return 124;
 }


Suggestion: The function getSwapTxFees has a TODO comment and returns a hardcoded value. It would be better to implement the function or, if it's not possible at the moment, throw an error or return a more meaningful default value.

Suggested change

export function getSwapTxFees(swap: GetSwapInfoResponse): number {

// TODO

return 124;

}

export function getSwapTxFees(swap: GetSwapInfoResponse): number {

throw new Error('Function getSwapTxFees not implemented yet');

}

CodiumAI-Agent · 2023-08-29T22:24:47Z

src/models/databaseModel.ts

+export function getSwapExchangeRate(swap: GetSwapInfoResponse): number {
+  const btcAmount = getSwapBtcAmount(swap);
+  const xmrAmount = getSwapXmrAmount(swap);

  return btcAmount / xmrAmount;
 }


Suggestion: The function getSwapExchangeRate doesn't handle the case where xmrAmount is 0, which would cause a division by zero error. It would be better to add a check for this case.

Suggested change

export function getSwapExchangeRate(swap: GetSwapInfoResponse): number {

const btcAmount = getSwapBtcAmount(swap);

const xmrAmount = getSwapXmrAmount(swap);

return btcAmount / xmrAmount;

}

export function getSwapExchangeRate(swap: GetSwapInfoResponse): number {

const btcAmount = getSwapBtcAmount(swap);

const xmrAmount = getSwapXmrAmount(swap);

if (xmrAmount === 0) {

throw new Error('XMR amount is zero, cannot calculate exchange rate');

}

return btcAmount / xmrAmount;

}

CodiumAI-Agent · 2023-08-29T22:24:48Z

src/models/rpcModel.ts

+export enum RpcMethod {
+  GET_BTC_BALANCE = 'get_bitcoin_balance',
+  WITHDRAW_BTC = 'withdraw_btc',
+  BUY_XMR = 'buy_xmr',
+  RESUME_SWAP = 'resume_swap',
+  LIST_SELLERS = 'list_sellers',
+  CANCEL_REFUND_SWAP = 'cancel_refund_swap',
+  GET_SWAP_INFO = 'get_swap_info',
+  SUSPEND_CURRENT_SWAP = 'suspend_current_swap',
+  GET_HISTORY = 'get_history',


Suggestion: Consider using a more descriptive name for the enum RpcMethod. The current name is not very descriptive of what the enum represents. A more descriptive name could be RpcSwapMethods or RpcSwapActions.

Suggested change

export enum RpcMethod {

GET_BTC_BALANCE = 'get_bitcoin_balance',

WITHDRAW_BTC = 'withdraw_btc',

BUY_XMR = 'buy_xmr',

RESUME_SWAP = 'resume_swap',

LIST_SELLERS = 'list_sellers',

CANCEL_REFUND_SWAP = 'cancel_refund_swap',

GET_SWAP_INFO = 'get_swap_info',

SUSPEND_CURRENT_SWAP = 'suspend_current_swap',

GET_HISTORY = 'get_history',

export enum RpcSwapMethods {

GET_BTC_BALANCE = 'get_bitcoin_balance',

WITHDRAW_BTC = 'withdraw_btc',

BUY_XMR = 'buy_xmr',

RESUME_SWAP = 'resume_swap',

LIST_SELLERS = 'list_sellers',

CANCEL_REFUND_SWAP = 'cancel_refund_swap',

GET_SWAP_INFO = 'get_swap_info',

SUSPEND_CURRENT_SWAP = 'suspend_current_swap',

GET_HISTORY = 'get_history',

}

CodiumAI-Agent · 2023-08-29T22:24:49Z

src/renderer/components/alert/RemainingFundsWillBeUsedAlert.tsx

+  const balance = useAppSelector((s) => s.rpc.state.balance);

  if (balance == null || balance <= 0) {
    return <></>;


Suggestion: Consider adding error handling for the case when balance is null. Currently, the code simply returns an empty fragment when balance is null or less than or equal to 0. It would be more user-friendly to display a message indicating that the balance could not be retrieved.

Suggested change

const balance = useAppSelector((s) => s.rpc.state.balance);

if (balance == null || balance <= 0) {

return <></>;

const balance = useAppSelector((s) => s.rpc.state.balance);

if (balance == null || balance <= 0) {

return <Alert severity="error">Could not retrieve balance</Alert>;

}

See comit-network/xmr-btc-swap#1673

This also changes the rpcSlice to store parsed logs

…d unparsed logs

binarybaron force-pushed the main branch from 5a5b16b to 042e12b Compare January 2, 2023 19:52

binarybaron force-pushed the main branch 2 times, most recently from 63958f1 to d58d4f9 Compare March 19, 2023 15:12

binarybaron added 9 commits August 29, 2023 22:30

Migrate balance and withdraw functionality from spawning a CLI proces…

62f79d2

…s to using the RPC API

Migrate rendezvous discovery to RPC API, cleanup

351cc2e

Move RPC functions to own file

380d2f4

Migrate database fetching to RPC API

62d7e25

Prettier write, BtcCancelledState doesnt need to exist for BtcRefunded

d7de124

Eliminate dead code: database states, redux slices, util functions

a3aaa71

Remove electrum-cash, sqlite dependencies

8b4e4e6

getCliLogSpanAttribute util function, set SwapId at init

8757e08

WIP: Remove all usages of internal database state -> migrate to API, …

36fd6b5

…prettify DebugPage and Logging

binarybaron force-pushed the cli-to-rpc branch from 4667d32 to 36fd6b5 Compare August 29, 2023 21:17

CodiumAI-Agent reviewed Aug 29, 2023

View reviewed changes

fix: Make text on SwapMightBeCancelledAlert less threating

6f89e2f

binarybaron force-pushed the cli-to-rpc branch from 960f508 to 6f89e2f Compare June 1, 2024 15:16

binarybaron added 14 commits June 6, 2024 12:31

fix: Tor socket

bf4a96c

fmt: Prettier

6fa3b63

feat: Config function for isExternalRpc

e72c090

ide: Remove vscode launch config

4e4e7f1

chore: Wording on SwapMightBeCancelled

30c2c82

feat: Config function for stub testnet provider

ee43ffb

chore: Change import paths from relative to absolute (where appropiate)

0aedb4d

Merge branch 'main' into cli-to-rpc

e5893c3

merge: Amend e5893c3

519d4df

feat: Parse new "Waiting for deposit" log message

8958403

See comit-network/xmr-btc-swap#1673

fmt: Prettier

8dc2a63

fmt: Imports

feb43ff

feat: Start Tor at startup (if no stub testnet provider is present)

93da858

fix: Absolute imports in main process

15811a7

binarybaron force-pushed the cli-to-rpc branch 2 times, most recently from 57ddb9a to d7b56b3 Compare June 12, 2024 13:36

feat: Display update dialog in React, store update infos in Redux

4e6fc19

binarybaron force-pushed the cli-to-rpc branch from d7b56b3 to b7971d5 Compare June 12, 2024 13:39

binarybaron added 6 commits June 12, 2024 15:40

chore: Remove blocked-at npm package, setZoomFactor to 1.2

0fe105d

feat: Fetch timelocks from RPC when new Bitcoin block is found

bcd5a26

This also changes the rpcSlice to store parsed logs

cli: Update to 0.13.1

beac137

fix: Update estimated time for states

d4ae3c1

chore: Fix padding for SwapWidget and Alerts

b6e8633

refactor: Change onLog callback for spawnSubcommand to take parsed an…

9e03a27

…d unparsed logs

binarybaron force-pushed the cli-to-rpc branch from b7971d5 to 9e03a27 Compare June 12, 2024 14:18

binarybaron added 2 commits June 12, 2024 17:01

fix: Wrong message for CliLogFinishedSyncingMoneroWallet

58ca101

fmt: Prettier

2a8e8fb

binarybaron merged commit 2a8e8fb into main Jun 12, 2024
0 of 5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cli to rpc #126

Cli to rpc #126

binarybaron commented Dec 20, 2022

binarybaron commented Aug 29, 2023

CodiumAI-Agent commented Aug 29, 2023

binarybaron commented Aug 29, 2023

CodiumAI-Agent Aug 29, 2023

CodiumAI-Agent Aug 29, 2023

CodiumAI-Agent Aug 29, 2023

CodiumAI-Agent Aug 29, 2023

CodiumAI-Agent Aug 29, 2023

CodiumAI-Agent Aug 29, 2023

CodiumAI-Agent Aug 29, 2023

CodiumAI-Agent Aug 29, 2023

CodiumAI-Agent Aug 29, 2023

CodiumAI-Agent Aug 29, 2023

CodiumAI-Agent Aug 29, 2023

CodiumAI-Agent Aug 29, 2023

CodiumAI-Agent Aug 29, 2023

CodiumAI-Agent Aug 29, 2023

Cli to rpc #126

Cli to rpc #126

Conversation

binarybaron commented Dec 20, 2022

binarybaron commented Aug 29, 2023

CodiumAI-Agent commented Aug 29, 2023

PR Analysis

PR Feedback

How to use

binarybaron commented Aug 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment